| Deviant Login | Shop | Join deviantART for FREE  |
Take the Tour  |
The Journal Portal
Browse Journals |
Polls |
deviantART [dee·vee·un'nt·ART]
Keep in Touch!
|
Deviousness `ChewedKandi has certainly gone out of her way to keep the vector community on the right path. Always making sure that her talents are infinitely scalable, Sharon has put her bezier curves to excellent use, and firmly anchored herself as an inspirational leader. We're absolutely delighted to bestow the Deviousness Award for June 2013 to `ChewedKandi. Congratulations, Sharon! Read More
|
Sta.sh
* Why define $query, when you could just put it into the function call?
* Why use a database, which can be unreliable, when a text file could suffice? Also, running two SQL queries every time the page is viewed puts unnecessary strain on the DB under heavy load.
* You could also use the session to remember a viewer and prevent them from racking up the count just by pressing refresh.
* Why kill the whole PHP page when an SQL error occurs for the page view counter? This seems over-kill when the rest of the page may work fine or not even use the database. I would place the counter in a function, and just exit the function on an error so that people could still use the site, even if the counter was not working.
* You shouldn't do "SELECT *" it's extra load on the server, always select just the fields you need.
* The second query could be built directly off of the first one, like thus:
$views=mysql_fetch_row(mysql_query("SELECT `num_views` FROM `counter`;",$connection))[0]++.";";
mysql_query("UPDATE `counter` SET `num_views`=$views;");
This would replace lines 6-13 with two lines, and I'm certain there's an even more compact way to do that in PHP.
Thanks very much for your time and effort to submit your code, I've enjoyed looking at it
I'll do my best to incorporate these into a possible future version, and then maybe make a direct comparison. Should be interesting. For now I can only say, I'm probably much more of a newb in PHP than you might think. But who knows, I'm always trying to learn.
Again, thanks!
$views=mysql_fetch_row(mysql_query("SELECT `num_views` FROM `counter`;",$connection))[0]++;
mysql_query("UPDATE `counter` SET `num_views`=$views;");
Nice one hon
Very usefull code tho
And thanks, I'll see what I can do.
Yep, tried it already, looks promising!